add evict call back func in lrucache #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@juzipeek |
…add call evict_cb at get with ttl item
lib/resty/lrucache.lua
Outdated
| if node.expire >= 0 and node.expire < ngx_now() then | ||
| -- print("expired: ", node.expire, " > ", ngx_now()) | ||
| if self.evict_cb then | ||
| pcall(self.evict_cb, key, val) |
There was a problem hiding this comment.
should we have a error log while running pcall failed? otherwise use will be confuse why their callback did not run.
There was a problem hiding this comment.
yea, i will add an errlog out put.
rainingmaster
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add evict call back func in lrucache, when obj been evict, call this func